-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
21404 when indexable creation is disabled cleanups are being scheduled upon post creation #21438
Conversation
Pull Request Test Coverage Report for Build 9d27661dd02a2b09f18724a5d3d2f87e91460c2bDetails
💛 - Coveralls |
Pull Request Test Coverage Report for Build 8e4c246a9641ab9403126878277d2a9402e15398Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR 🏗️
Some small comments.
Plus I wonder if it would be worth the refactor now. Creating a helper method for scheduling instead of repeating more logic all over? The only place with another time is the activation-cleanup-integration; Using a day instead of 5 minutes. But could pass that still?
Might also be overkill, it is just a thought 🙂
tests/Unit/Integrations/Watchers/Indexable_Taxonomy_Change_Watcher_Test.php
Outdated
Show resolved
Hide resolved
… into 21404-when-indexable-creation-is-disabled-cleanups-are-being-scheduled-upon-post-creation # Conflicts: # composer.json
No longer retrieving the option
Pull Request Test Coverage Report for Build 4ae3d69694156ef946f5bd62add6a8bc45c9fa00Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR && AC ✅
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Note: Wherever
add_filter( 'Yoast\WP\SEO\should_index_indexables', '__return_false' );
is mentioned, it can also mean that you are on a non-production site instead (aka, have theWP_ENVIRONMENT_TYPE
constant indicate a staging or local or development site).wpseo_start_cleanup_indexables
. If there is remove it by hovering over the cron and clicking delete. Refresh the page to make sure it has happend.Activation of the plugin for the second time.
add_filter( 'Yoast\WP\SEO\should_index_indexables', '__return_false' );
filter active somewhere on your site.wpseo_start_cleanup_indexables
should not be present in the cron overview.wpseo_start_cleanup_indexables
cron should be visible.Disable attachment indexables
add_filter( 'Yoast\WP\SEO\should_index_indexables', '__return_false' );
filter active somewhere on your site.wpseo_start_cleanup_indexables
cron.Disable author archives
add_filter( 'Yoast\WP\SEO\should_index_indexables', '__return_false' );
filter active somewhere on your site.wpseo_start_cleanup_indexables
cron.Remove a taxonomy
add_filter( 'Yoast\WP\SEO\should_index_indexables', '__return_false' );
filter active somewhere on your site.wpseo_start_cleanup_indexables
cron.Remove a post type
add_filter( 'Yoast\WP\SEO\should_index_indexables', '__return_false' );
filter active somewhere on your site.wpseo_start_cleanup_indexables
cron.Remove post from author
add_filter( 'Yoast\WP\SEO\should_index_indexables', '__return_false' );
filter active somewhere on your site.wpseo_start_cleanup_indexables
cron.Make sure the cron is not there.
Run the cleanup
To test if the cleanup will not run with the filter enabled we will try to remove author archive indexables that are no longer needed.
wpseo_start_cleanup_indexables
cron.add_filter( 'Yoast\WP\SEO\should_index_indexables', '__return_false' );
filter active somewhere on your site.run now
on the cron. And make sure the author indexable is still there.Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo]
, added test instructions for Shopify and attached theShopify
label to this PR.Documentation
Quality assurance
Innovation
innovation
label.Fixes #